netdev - Re: DSA incompatible with TI CPSW device model in dual mac mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190121165538.GG8620@lunn.ch>
Date:   Mon, 21 Jan 2019 17:55:38 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Daniele Orlandi <daniele@...andi.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: DSA incompatible with TI CPSW device model in dual mac mode

On Mon, Jan 21, 2019 at 03:57:32PM +0100, Daniele Orlandi wrote:
> On 20/01/19 18:30, Andrew Lunn wrote:
> >
> >Looking at Documentation/devicetree/bindings/net/cpsw.txt, your DSA
> >Ethernet phandle should point to cpsw_emac1: slave@1.
> 
> Hi Andrew,
> 
> Yes, that's what sounds logical, however that node does not become the
> parent device net class nodes:
> 
> root@...0:/sys/class/net# ls -l
> [...]
> lrwxrwxrwx    1 root     root             0 Jan  1  1970 eth0 ->
> ../../devices/platform/ocp/4a100000.ethernet/net/eth0
> lrwxrwxrwx    1 root     root             0 Jan  1  1970 eth1 ->
> ../../devices/platform/ocp/4a100000.ethernet/net/eth1
> [...]
> 
> root@...0:/sys/class/net# cd eth0
> root@...0:/sys/devices/platform/ocp/4a100000.ethernet/net/eth0# ls -l
> [...]
> lrwxrwxrwx    1 root     root             0 Jan  1  1970 device ->
> ../../../4a100000.ethernet
> [...]
> 
> root@...0:/sys/class/net# cd eth1
> root@...0:/sys/devices/platform/ocp/4a100000.ethernet/net/eth1# ls -l
> [...]
> lrwxrwxrwx    1 root     root             0 Jan  1  1970 device ->
> ../../../4a100000.ethernet
> [...]
> 
> > I don't know if this actually works, but i _think_ some people have used
> DSA with this
> >device.
> 
> IMHO it should be the CPSW driver that should istantiate two separate
> devices, one for each cpsw_emacX node in the device tree.
> 
> Do you think they could be receptive to such proposal?

Hi Danielse

I suggest you ask. Or post a patch.

CPSW does all sorts of things in odd ways. So i would always expect
trouble with this device. From what i hear, there is a new driver
being written for it, so hopefully that driver will be more normal and
easier to use.

       Andrew