netdev - Re: [PATCH v2 iproute2] ip: support for xfrm interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Jan 2019 12:05:14 -0500
From:   Matt Ellison <matt@...oyo.io>
To:     David Ahern <dsahern@...il.com>
Cc:     netdev@...r.kernel.org, stephen@...workplumber.org
Subject: Re: [PATCH v2 iproute2] ip: support for xfrm interfaces

On Mon, 21 Jan 2019 09:14:52 -0700 David Ahern <dsahern@...il.com> wrote:

> You always add IF_ID even if not set by user. The kernel code does not
> appear to require it so why pass a default value?

0 (the default) is a valid IF_ID, so setting an interface with a non-zero IF_ID 
back to 0 is possible. I think the better solution would be to check for existing
values so an "ip link set" doesn't try and automatically use 0 if unsepcified.

> The kernel code does appear to require this parameter, so why have
> this requirement in iproute2?

Looks to be required, without the check I get:
RTNETLINK answers: No such device

> What about IFLA_XFRM_LINK?

It shows up as the parent interface when you ip link show: 

13: xfrm2@...n0: <NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
    link/none 48:e2:44:f6:77:51 brd ff:ff:ff:ff:ff:ff

But I can print it again if you think I should.

-- 

Please be advised that this email may contain confidential information. 
If you are not the intended recipient, please notify us by email by 
replying to the sender and delete this message. The sender disclaims that 
the content of this email constitutes an offer to enter into, or the 
acceptance of, any agreement; provided that the foregoing does not 
invalidate the binding effect of any digital or other electronic 
reproduction of a manual signature that is included in any attachment.

<https://twitter.com/arroyo_networks>   
<https://www.linkedin.com/company/arroyo-networks>   
<https://www.github.com/ArroyoNetworks>