netdev - Re: [PATCH] RFC: Revert "net: phy: check return code when requesting PHY driver module"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190121175717.GA30032@bogon.m.sigxcpu.org>
Date:   Mon, 21 Jan 2019 18:57:17 +0100
From:   Guido Günther <agx@...xcpu.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] RFC: Revert "net: phy: check return code when requesting
 PHY driver module"

Hi,
On Mon, Jan 21, 2019 at 05:26:00PM +0100, Andrew Lunn wrote:
> On Mon, Jan 21, 2019 at 03:00:55PM +0100, Guido Günther wrote:
> > This unbreaks ethernet on e.g. the NXP imx8mq-evk using the fec driver.
> > Otherwise it fails like:
> > 
> > [    3.702671] device: '30be0000.ethernet-1': device_add
> > [    3.707783] PM: Adding info for No Bus:30be0000.ethernet-1
> > [    3.713329] libphy: fec_enet_mii_bus: probed
> > [    3.717815] mdio_bus 30be0000.ethernet-1:01: error -2 loading PHY driver module for ID 0x004dd074
> > [    3.726747] PM: Removing info for No Bus:30be0000.ethernet-1
> > [    3.732460] device: 'pps0': device_unregister
> > [    3.736911] PM: Removing info for No Bus:pps0
> > [    3.741317] device: 'ptp0': device_unregister
> > [    3.745761] PM: Removing info for No Bus:ptp0
> > [    3.750160] device: 'ptp0': device_create_release
> > [    3.755024] fec 30be0000.ethernet: Dropping the link to regulator.2
> > [    3.761359] fec: probe of 30be0000.ethernet failed with error -2
> > 
> > This reverts commit 13d0ab6750b20957ac1466da4e44dc0af746ff28.
> 
> Hi Guido
> 
> Please could you test:
> 
> https://www.spinics.net/lists/netdev/msg545573.html

Yes, that works. There's indeed no initramfs in this case and the
module is built into the kernel. Feel free to add a

    Tested-By: Guido Günther <agx@...xcpu.org>

Cheers,
 -- Guido