netdev - Re: [PATCH] net: phy: Fixup GPLv2+ SPDX tags based on license text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98ba7abb-5b3f-1216-87fa-20443b6720a7@gmail.com>
Date:   Tue, 22 Jan 2019 08:16:12 +1300
From:   Michael Schmitz <schmitzmic@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        David Wu <david.wu@...k-chips.com>,
        Dongpo Li <lidongpo@...ilicon.com>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] net: phy: Fixup GPLv2+ SPDX tags based on license text

For the asix.c patch:

Acked-by: Michael Schmitz <schmitzmic@...il.com>

On 22/01/19 7:08 AM, Andrew Lunn wrote:
> A few PHY drivers have the GPLv2+ license text. They then either have
> a MODULE_LICENSE() of GPLv2 only, or an SPDX tag of GPLv2 only.
>
> Since the license text is much easier to understand than either the
> SPDX tag or the MODULE_LICENSE, use it as the definitive source of the
> licence, and fixup the others when there are contradictions.
>
> Cc: David Wu <david.wu@...k-chips.com>
> Cc: Dongpo Li <lidongpo@...ilicon.com>
> Cc: Michael Schmitz <schmitzmic@...il.com>
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> ---
>   drivers/net/phy/asix.c            |  8 +-------
>   drivers/net/phy/mdio-hisi-femac.c | 16 ++--------------
>   drivers/net/phy/rockchip.c        |  9 ++-------
>   3 files changed, 5 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/net/phy/asix.c b/drivers/net/phy/asix.c
> index 8ebe7f5484ae..f14ba5366b91 100644
> --- a/drivers/net/phy/asix.c
> +++ b/drivers/net/phy/asix.c
> @@ -1,13 +1,7 @@
> -// SPDX-License-Identifier: GPL-2.0
> +// SPDX-License-Identifier: GPL-2.0+
>   /* Driver for Asix PHYs
>    *
>    * Author: Michael Schmitz <schmitzmic@...il.com>
> - *
> - * This program is free software; you can redistribute  it and/or modify it
> - * under  the terms of  the GNU General  Public License as published by the
> - * Free Software Foundation;  either version 2 of the  License, or (at your
> - * option) any later version.
> - *
>    */
>   #include <linux/kernel.h>
>   #include <linux/errno.h>
> diff --git a/drivers/net/phy/mdio-hisi-femac.c b/drivers/net/phy/mdio-hisi-femac.c
> index b03fedd6c1d8..287f3ccf1da1 100644
> --- a/drivers/net/phy/mdio-hisi-femac.c
> +++ b/drivers/net/phy/mdio-hisi-femac.c
> @@ -1,20 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0+
>   /*
>    * Hisilicon Fast Ethernet MDIO Bus Driver
>    *
>    * Copyright (c) 2016 HiSilicon Technologies Co., Ltd.
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program. If not, see <http://www.gnu.org/licenses/>.
>    */
>   
>   #include <linux/clk.h>
> @@ -163,4 +151,4 @@ module_platform_driver(hisi_femac_mdio_driver);
>   
>   MODULE_DESCRIPTION("Hisilicon Fast Ethernet MAC MDIO interface driver");
>   MODULE_AUTHOR("Dongpo Li <lidongpo@...ilicon.com>");
> -MODULE_LICENSE("GPL v2");
> +MODULE_LICENSE("GPL");
> diff --git a/drivers/net/phy/rockchip.c b/drivers/net/phy/rockchip.c
> index f1da70b9b55f..95abf7072f32 100644
> --- a/drivers/net/phy/rockchip.c
> +++ b/drivers/net/phy/rockchip.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0+
>   /**
>    * drivers/net/phy/rockchip.c
>    *
> @@ -6,12 +7,6 @@
>    * Copyright (c) 2017, Fuzhou Rockchip Electronics Co., Ltd
>    *
>    * David Wu <david.wu@...k-chips.com>
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
>    */
>   
>   #include <linux/ethtool.h>
> @@ -229,4 +224,4 @@ MODULE_DEVICE_TABLE(mdio, rockchip_phy_tbl);
>   
>   MODULE_AUTHOR("David Wu <david.wu@...k-chips.com>");
>   MODULE_DESCRIPTION("Rockchip Ethernet PHY driver");
> -MODULE_LICENSE("GPL v2");
> +MODULE_LICENSE("GPL");