netdev - Re: [RFC bpf-next PATCH] samples/bpf: xdp_redirect_cpu have not need for read_trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190121093953.7d9e7b03@maciek-lenovo>
Date:   Mon, 21 Jan 2019 09:39:53 +0100
From:   Maciej Fijałkowski 
        <maciejromanfijalkowski@...il.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Daniel Borkmann <borkmann@...earbox.net>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [RFC bpf-next PATCH] samples/bpf: xdp_redirect_cpu have not
 need for read_trace_pipe

Dnia 2019-01-17, o godz. 12:26:47
Jesper Dangaard Brouer <brouer@...hat.com> napisał(a):

> The sample xdp_redirect_cpu is not using helper bpf_trace_printk.
> Thus it makes no sense that the --debug option us reading
> from /sys/kernel/debug/tracing/trace_pipe via read_trace_pipe.
> Simply remove it.
> 
> Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>
> ---
> I request that Maciej Fijalkowski <maciejromanfijalkowski@...il.com>
> will take and integrate this patch in his patchset, such that
> we can also complete the conversion of xdp_redirect_cpu to libbpf.
>
Let me include your patch and send a v2 :)

>  samples/bpf/xdp_redirect_cpu_user.c |   10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/samples/bpf/xdp_redirect_cpu_user.c
> b/samples/bpf/xdp_redirect_cpu_user.c index 2d23054aaccf..f141e752ca0a 100644
> --- a/samples/bpf/xdp_redirect_cpu_user.c
> +++ b/samples/bpf/xdp_redirect_cpu_user.c
> @@ -51,7 +51,6 @@ static const struct option long_options[] = {
>  	{"help",	no_argument,		NULL, 'h' },
>  	{"dev",		required_argument,	NULL, 'd' },
>  	{"skb-mode",	no_argument,		NULL, 'S' },
> -	{"debug",	no_argument,		NULL, 'D' },
>  	{"sec",		required_argument,	NULL, 's' },
>  	{"prognum",	required_argument,	NULL, 'p' },
>  	{"qsize",	required_argument,	NULL, 'q' },
> @@ -563,7 +562,6 @@ int main(int argc, char **argv)
>  	bool use_separators = true;
>  	bool stress_mode = false;
>  	char filename[256];
> -	bool debug = false;
>  	int added_cpus = 0;
>  	int longindex = 0;
>  	int interval = 2;
> @@ -624,9 +622,6 @@ int main(int argc, char **argv)
>  		case 'S':
>  			xdp_flags |= XDP_FLAGS_SKB_MODE;
>  			break;
> -		case 'D':
> -			debug = true;
> -			break;
>  		case 'x':
>  			stress_mode = true;
>  			break;
> @@ -688,11 +683,6 @@ int main(int argc, char **argv)
>  		return EXIT_FAIL_XDP;
>  	}
>  
> -	if (debug) {
> -		printf("Debug-mode reading trace pipe (fix #define
> DEBUG)\n");
> -		read_trace_pipe();
> -	}
> -
>  	stats_poll(interval, use_separators, prog_num, stress_mode);
>  	return EXIT_OK;
>  }
>