netdev - Re: [PATCH net-next v2 01/11] devlink: Add health buffer support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ffae8881-4cea-c268-648c-37a3df753e9e@mellanox.com>
Date:   Mon, 21 Jan 2019 11:07:14 +0000
From:   Eran Ben Elisha <eranbe@...lanox.com>
To:     David Miller <davem@...emloft.net>,
        "jiri@...nulli.us" <jiri@...nulli.us>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Ariel Almog <ariela@...lanox.com>,
        Aya Levin <ayal@...lanox.com>,
        Moshe Shemesh <moshe@...lanox.com>
Subject: Re: [PATCH net-next v2 01/11] devlink: Add health buffer support

On 1/20/2019 8:45 PM, David Miller wrote:
> From: Jiri Pirko <jiri@...nulli.us>
> Date: Sun, 20 Jan 2019 12:08:50 +0100
> 
>> I haven't have time to review this due to travel. I think it was mistake
>> to merge this as the buffer api is wrong in my opinion. I would vote for
>> revert if possible.
> 
> Let's spend a couple days trying to fix things up first.

will do.
I reviewed the comments and saw that the major comment is around the 
"Devlink buffers", which Jiri asked to replace with "Devlink msg".

The issue is that there is no easy way to modify one into the other 
without breaking things, so I am planning to provide a series on top 
which does:
1. Add devlink msg API
2. Move devlink reporter to use new API
3. Move existing reporter to use the new API
4. Get rid of the old API

thanks,
Eran

> 
> I cannot make contributors hostage to other people's travel
> schedule, no way.
> 
> If it seems hopeless by Wednesday, I will revert.

Should be published by then, hopefully sooner.

> 
> Thanks.
>