netdev - Re: [PATCH 07/11] arm64: dts: renesas: cat875: Add ethernet support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190122145529.zuxpni2klc4lxdxn@verge.net.au>
Date:   Tue, 22 Jan 2019 15:55:29 +0100
From:   Simon Horman <horms@...ge.net.au>
To:     Fabrizio Castro <fabrizio.castro@...renesas.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Biju Das <biju.das@...renesas.com>,
        Magnus Damm <magnus.damm@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Thierry Reding <treding@...dia.com>,
        Andreas Färber <afaerber@...e.de>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Kevin Hilman <khilman@...libre.com>,
        Johan Hovold <johan@...nel.org>,
        Lukasz Majewski <lukma@...x.de>,
        Michal Simek <monstr@...str.eu>,
        Michal Vokáč <michal.vokac@...ft.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Ben Whitten <ben.whitten@...il.com>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "ebiharaml@...linux.co.jp" <ebiharaml@...linux.co.jp>
Subject: Re: [PATCH 07/11] arm64: dts: renesas: cat875: Add ethernet support

On Sun, Jan 20, 2019 at 09:28:45AM +0100, Simon Horman wrote:
> On Thu, Jan 17, 2019 at 01:27:51PM +0000, Fabrizio Castro wrote:
> > Hello Simon,
> > 
> > Thank you for your feedback!
> > 
> > > From: Simon Horman <horms@...ge.net.au>
> > > Sent: 17 January 2019 12:00
> > > Subject: Re: [PATCH 07/11] arm64: dts: renesas: cat875: Add ethernet support
> > >
> > > On Wed, Jan 16, 2019 at 06:37:50PM +0000, Fabrizio Castro wrote:
> > > > From: Biju Das <biju.das@...renesas.com>
> > > >
> > > > This patch adds ethernet support to the sub board.
> > > >
> > > > Signed-off-by: Biju Das <biju.das@...renesas.com>
> > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@...renesas.com>
> > > > Reviewed-by: Chris Paterson <Chris.Paterson2@...esas.com>
> > > > ---
> > > >  arch/arm64/boot/dts/renesas/cat875.dtsi | 30 ++++++++++++++++++++++++++++++
> > > >  1 file changed, 30 insertions(+)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/renesas/cat875.dtsi b/arch/arm64/boot/dts/renesas/cat875.dtsi
> > > > index a41d0d8..805ffa7 100644
> > > > --- a/arch/arm64/boot/dts/renesas/cat875.dtsi
> > > > +++ b/arch/arm64/boot/dts/renesas/cat875.dtsi
> > > > @@ -7,4 +7,34 @@
> > > >
> > > >  / {
> > > >  model = "Silicon Linux sub board for CAT874 (CAT875)";
> > > > +
> > > > +aliases {
> > > > +ethernet0 = &avb;
> > > > +};
> > > > +};
> > > > +
> > > > +&avb {
> > > > +pinctrl-0 = <&avb_pins>;
> > > > +pinctrl-names = "default";
> > > > +renesas,no-ether-link;
> > >
> > > Is the renesas,no-ether-link required?
> > 
> > The AVB_LINK pin from the SoC is connected to the PMEB (Power Management Event, B stands for
> > active low) pin on the  PHY, which means it is not a link signal. The PMEB signal is active when a magic
> > packet or a wake up frame are detected. As a result, we need renesas,no-ether-link and we can't
> > specify avb_link with avb_pin either.
> 
> Thanks for following-up. In that case I am fine with this patch.
> 

Thanks again, applied for v5.1.