netdev - Re: [PATCHv3 2/3] net: dsa: mt7530: support the 7530 switch on the Mediatek MT7621 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b8ccfc90-32ae-1903-b202-4d51cc0de34d@kernel.org>
Date:   Tue, 22 Jan 2019 11:28:03 +1000
From:   Greg Ungerer <gerg@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     sean.wang@...iatek.com, bjorn@...k.no,
        vivien.didelot@...oirfairelinux.com, f.fainelli@...il.com,
        netdev@...r.kernel.org, rene@...rst.com, john@...ozen.org,
        neil@...wn.name
Subject: Re: [PATCHv3 2/3] net: dsa: mt7530: support the 7530 switch on the
 Mediatek MT7621 SoC



On 22/1/19 3:04 am, Andrew Lunn wrote:
> On Mon, Jan 21, 2019 at 05:11:39PM +1000, gerg@...nel.org wrote:
>> From: Greg Ungerer <gerg@...nel.org>
>>
>> The MediaTek MT7621 SoC device contains a 7530 switch, and the existing
>> linux kernel 7530 DSA switch driver can be used with it.
>>
>> The bulk of the changes required stem from the 7621 having different
>> regulator and pad setup. The existing setup of these in the 7530
>> driver appears to be very specific to its implemtation in the Mediatek
>> 7623 SoC. (Not entirely surprising given the 7623 is a quad core ARM
>> based SoC, and the 7621 is a dual core, dual thread MIPS based SoC).
>>
>> Create a new devicetree type, "mediatek,mt7621", to support the 7530
>> switch in the 7621 SoC. There appears to be no usable ID register to
>> distinguish it from a 7530 in other hardware at runtime. This is used
>> to carry out the appropriate configuration and setup.
>>
>> Signed-off-by: Greg Ungerer <gerg@...nel.org>
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>

Thanks Andrew, I'll add those reviewed by tags.

Regards
Greg