netdev - Re: [net-next 2/3] net/tls: free ctx in sock destruct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190122.113745.2272490918452641096.davem@davemloft.net>
Date:   Tue, 22 Jan 2019 11:37:45 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     atul.gupta@...lsio.com
Cc:     herbert@...dor.apana.org.au, linux-crypto@...r.kernel.org,
        netdev@...r.kernel.org, dt@...lsio.com
Subject: Re: [net-next 2/3] net/tls: free ctx in sock destruct

From: Atul Gupta <atul.gupta@...lsio.com>
Date: Thu, 17 Jan 2019 20:56:21 -0800

> free tls context in sock destruct. close may not be the last
> call to free sock but force releasing the ctx in close
> will result in GPF when ctx referred again in tcp_done
> 
> [  515.330477] general protection fault: 0000 [#1] SMP PTI
> [  515.330539] CPU: 5 PID: 0 Comm: swapper/5 Not tainted 4.20.0-rc7+ #10
> [  515.330657] Hardware name: Supermicro X8ST3/X8ST3, BIOS 2.0b
> 11/07/2013
> [  515.330844] RIP: 0010:tls_hw_unhash+0xbf/0xd0
> [
> [  515.332220] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [  515.332340] CR2: 00007fab32c55000 CR3: 000000009261e000 CR4:
> 00000000000006e0
> [  515.332519] Call Trace:
> [  515.332632]  <IRQ>
> [  515.332793]  tcp_set_state+0x5a/0x190
> [  515.332907]  ? tcp_update_metrics+0xe3/0x350
> [  515.333023]  tcp_done+0x31/0xd0
> [  515.333130]  tcp_rcv_state_process+0xc27/0x111a
> [  515.333242]  ? __lock_is_held+0x4f/0x90
> [  515.333350]  ? tcp_v4_do_rcv+0xaf/0x1e0
> [  515.333456]  tcp_v4_do_rcv+0xaf/0x1e0
> 
> Signed-off-by: Atul Gupta <atul.gupta@...lsio.com>

Applied.