netdev - Re: [PATCH net v2] net: ip_gre: use erspan key field for tunnel lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 22 Jan 2019 11:53:06 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     lorenzo.bianconi@...hat.com
Cc:     netdev@...r.kernel.org, u9012063@...il.com, dcaratti@...hat.com
Subject: Re: [PATCH net v2] net: ip_gre: use erspan key field for tunnel
 lookup

From: Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
Date: Fri, 18 Jan 2019 12:05:39 +0100

> Use ERSPAN key header field as tunnel key in gre_parse_header routine
> since ERSPAN protocol sets the key field of the external GRE header to
> 0 resulting in a tunnel lookup fail in ip6gre_err.
> In addition remove key field parsing and pskb_may_pull check in
> erspan_rcv and ip6erspan_rcv
> 
> Fixes: 5a963eb61b7c ("ip6_gre: Add ERSPAN native tunnel support")
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
> ---
> Changes since v1:
> - verify that ershdr is in the skb linear area
> - remove duplicated pskb_may_pull checks in erspan_rcv and
>   ip6erspan_rcv  

Applied and queued up for -stable, thank you.