netdev - Re: [PATCH] ip_gre: Fix the wrong err return code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190122.120227.1146416971992878711.davem@davemloft.net>
Date:   Tue, 22 Jan 2019 12:02:27 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     wenxu@...oud.cn
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] ip_gre: Fix the wrong err return code

From: wenxu@...oud.cn
Date: Fri, 18 Jan 2019 20:13:15 +0800

> From: wenxu <wenxu@...oud.cn>
> 
> Fixes: 862a03c ("gre: refactor the gre_fb_xmit")
>        1a66a83 ("gre: add collect_md mode to ERSPAN tunnel")
> 
> Signed-off-by: wenxu <wenxu@...oud.cn>
> ---
>  net/ipv4/ip_gre.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
> index d1d09f3..970500a 100644
> --- a/net/ipv4/ip_gre.c
> +++ b/net/ipv4/ip_gre.c
> @@ -544,7 +544,7 @@ static void gre_fb_xmit(struct sk_buff *skb, struct net_device *dev,
>  
>  	rt = prepare_fb_xmit(skb, dev, &fl, tunnel_hlen);
>  	if (!rt)
> -		return;
> +		goto err_free_skb;
>  

prepare_fb_xmit() frees the SKB when it returns NULL, so your change will free
the SKB twice.

I'm not applying this.