netdev - Re: [PATCH] net: core: dev: Initialise napi state correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 22 Jan 2019 14:38:06 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     mckay.david@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net: core: dev: Initialise napi state correctly

From: Dave McKay <mckay.david@...il.com>
Date: Fri, 18 Jan 2019 12:46:32 +0000

> The state member of the napi_struct is not initialised correctly, it
> sets the SCHED bit without initialising the state to zero first. This
> results in peculiar behaviour if the original napi_struct didn't come
> from a zero initialised region to start with.
> 
> This patch just sets it directly using the appropriate bitfield
> constant.
> 
> Signed-off-by: Dave McKay <mckay.david@...il.com>

Caller needs to pass in properly initialized memory, that means
bzero()'d.