netdev - Re: [PATCH net-next] net: phy: fix issue with loading PHY driver w/o initramfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Jan 2019 14:45:14 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     krzk@...nel.org, andrew@...n.ch, f.fainelli@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: fix issue with loading PHY driver
 w/o initramfs

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Sat, 19 Jan 2019 10:30:21 +0100

> It was reported that on a system with nfsboot and w/o initramfs network
> fails because trying to load the PHY driver returns -ENOENT. Reason was
> that due to missing initramfs the modprobe binary isn't available.
> So we have to ignore error code -ENOENT.
> 
> Fixes: 13d0ab6750b2 ("net: phy: check return code when requesting PHY driver module")
> Reported-by: Krzysztof Kozlowski <krzk@...nel.org>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied.

However, I agree with Geert that we should adopt the:

	if (module_not_present)
		request_module();
	if (module_not_present)
		goto failed_to_load;

pattern.