netdev - Re: [for next][PATCH] iwlwifi: Fix unmet dependency error for IWLWIFI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ef50896ee3ecc895c72a9fbdedca65ac6433fef2.camel@intel.com>
Date:   Tue, 22 Jan 2019 12:15:03 +0200
From:   Luciano Coelho <luciano.coelho@...el.com>
To:     Sinan Kaya <okaya@...nel.org>, linux-next@...r.kernel.org
Cc:     Johannes Berg <johannes.berg@...el.com>,
        Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
        Intel Linux Wireless <linuxwifi@...el.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S. Miller" <davem@...emloft.net>,
        "open list:INTEL WIRELESS WIFI LINK (iwlwifi)" 
        <linux-wireless@...r.kernel.org>,
        "open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [for next][PATCH] iwlwifi: Fix unmet dependency error for
 IWLWIFI_LEDS

On Mon, 2019-01-21 at 23:31 +0000, Sinan Kaya wrote:
> There is an unresolved dependency as follows:
> 
> IWLWIFI_LEDS selects MAC80211_LEDS.
> MAC80211_LEDS depends on MAC80211.
> 
> It is possible to choose MAC80211_LEDS (y) but not choose MAC80211
> (n)
> 
> WARNING: unmet direct dependencies detected for MAC80211_LEDS
>   Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=n] &&
> LEDS_CLASS [=y]
>   Selected by [y]:
>   - IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] &&
> WLAN_VENDOR_INTEL [=y] && IWLWIFI [=y] && (LEDS_CLASS [=y]=y ||
> LEDS_CLASS [=y]=IWLWIFI [=y])
> 
> Move the MAC80211 dependency into IWLWIFI_LEDS so that we avoid this
> configuration.
> 
> Signed-off-by: Sinan Kaya <okaya@...nel.org>
> ---

Thanks for your patch! But we already have another patch to fix this
issued queued for 5.0-rc4 (it's currently in wireless-drivers.git):

https://patchwork.kernel.org/patch/10762079/

--
Cheers,
Luca.