lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAACQVJqno=Z_Sx-8cv_Q69eyuUZD_tkWhWRA7HGFNQEgoEcP3Q@mail.gmail.com> Date: Wed, 23 Jan 2019 17:06:40 +0530 From: Vasundhara Volam <vasundhara-v.volam@...adcom.com> To: Jiri Pirko <jiri@...nulli.us> Cc: David Miller <davem@...emloft.net>, "michael.chan@...adcom.com" <michael.chan@...adcom.com>, Jiri Pirko <jiri@...lanox.com>, Jakub Kicinski <jakub.kicinski@...ronome.com>, mkubecek@...e.cz, Netdev <netdev@...r.kernel.org> Subject: Re: [PATCH net-next v7 4/8] devlink: Add support for driverinit get value for devlink_port On Wed, Jan 23, 2019 at 4:47 PM Jiri Pirko <jiri@...nulli.us> wrote: > > Fri, Jan 18, 2019 at 08:09:41AM CET, vasundhara-v.volam@...adcom.com wrote: > >Add support for "driverinit" configuration mode value for devlink_port > >configuration parameters. Add devlink_port_param_driverinit_value_get() > >function to help the driver get the value from devlink_port. > > > >Also, move the common code to __devlink_param_driverinit_value_get() > >to be used by both device and port params. > > > >Cc: Jiri Pirko <jiri@...lanox.com> > >Signed-off-by: Vasundhara Volam <vasundhara-v.volam@...adcom.com> > >--- > > include/net/devlink.h | 8 ++++++ > > net/core/devlink.c | 67 ++++++++++++++++++++++++++++++++++++++------------- > > 2 files changed, 58 insertions(+), 17 deletions(-) > > > >diff --git a/include/net/devlink.h b/include/net/devlink.h > >index 98b8a66..09f3f43 100644 > >--- a/include/net/devlink.h > >+++ b/include/net/devlink.h > >@@ -838,6 +838,14 @@ static inline bool devlink_dpipe_table_counter_enabled(struct devlink *devlink, > > { > > } > > > >+static inline int > >+devlink_port_param_driverinit_value_get(struct devlink_port *devlink_port, > >+ u32 param_id, > >+ union devlink_param_value *init_val) > >+{ > >+ return -EOPNOTSUPP; > >+} > > > You are missing function declaration in case IS_ENABLED(CONFIG_NET_DEVLINK > > Otherwise this looks fine. Thank you for pointing. It is a mistake. I will fix it in next version. > > > >+ > > static inline struct devlink_region * > > devlink_region_create(struct devlink *devlink, > > const char *region_name, > > [...] >
Powered by blists - more mailing lists