lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1598bfeb-0061-1d52-6b10-a3740ee25f46@mellanox.com> Date: Wed, 23 Jan 2019 12:29:13 +0000 From: Tariq Toukan <tariqt@...lanox.com> To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>, Tariq Toukan <tariqt@...lanox.com>, "David S. Miller" <davem@...emloft.net> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH net-next] net/mlx4: Mark expected switch fall-through On 1/23/2019 10:05 AM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > This patch fixes the following warning: > > drivers/net/ethernet/mellanox/mlx4/eq.c: In function ‘mlx4_eq_int’: > drivers/net/ethernet/mellanox/mlx4/mlx4.h:219:5: warning: this statement may fall through [-Wimplicit-fallthrough=] > if (mlx4_debug_level) \ > ^ > drivers/net/ethernet/mellanox/mlx4/eq.c:558:4: note: in expansion of macro ‘mlx4_dbg’ > mlx4_dbg(dev, "%s: MLX4_EVENT_TYPE_SRQ_LIMIT. srq_no=0x%x, eq 0x%x\n", > ^~~~~~~~ > drivers/net/ethernet/mellanox/mlx4/eq.c:561:3: note: here > case MLX4_EVENT_TYPE_SRQ_CATAS_ERROR: > ^~~~ > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > This patch is part of the ongoing efforts to enabling > -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com> > --- > drivers/net/ethernet/mellanox/mlx4/eq.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/mellanox/mlx4/eq.c b/drivers/net/ethernet/mellanox/mlx4/eq.c > index 4953c852c247..2f4201023836 100644 > --- a/drivers/net/ethernet/mellanox/mlx4/eq.c > +++ b/drivers/net/ethernet/mellanox/mlx4/eq.c > @@ -558,6 +558,7 @@ static int mlx4_eq_int(struct mlx4_dev *dev, struct mlx4_eq *eq) > mlx4_dbg(dev, "%s: MLX4_EVENT_TYPE_SRQ_LIMIT. srq_no=0x%x, eq 0x%x\n", > __func__, be32_to_cpu(eqe->event.srq.srqn), > eq->eqn); > + /* fall through */ > case MLX4_EVENT_TYPE_SRQ_CATAS_ERROR: > if (mlx4_is_master(dev)) { > /* forward only to slave owning the SRQ */ > Reviewed-by: Tariq Toukan <tariqt@...lanox.com> Thanks for your patch.
Powered by blists - more mailing lists