netdev - Re: [PATCH 3/7] net/ethernet: Add parse_protocol header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-+B6atsSbYV6Dk3qTdxtxmpqZXEen_eGFDqkHYJOe=zCQ@mail.gmail.com>
Date:   Wed, 23 Jan 2019 09:14:59 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Maxim Mikityanskiy <maximmi@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Jason Wang <jasowang@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Eran Ben Elisha <eranbe@...lanox.com>,
        Tariq Toukan <tariqt@...lanox.com>
Subject: Re: [PATCH 3/7] net/ethernet: Add parse_protocol header_ops support

On Mon, Jan 14, 2019 at 8:21 AM Maxim Mikityanskiy <maximmi@...lanox.com> wrote:
>
> The previous commit introduced parse_protocol callback which should
> extract the protocol number from the L2 header. Make all Ethernet
> devices support it.
>
> Signed-off-by: Maxim Mikityanskiy <maximmi@...lanox.com>
> ---
>  include/linux/etherdevice.h |  1 +
>  net/ethernet/eth.c          | 13 +++++++++++++
>  2 files changed, 14 insertions(+)
>
> diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h
> index 2c0af7b00715..e2f3b21cd72a 100644
> --- a/include/linux/etherdevice.h
> +++ b/include/linux/etherdevice.h
> @@ -44,6 +44,7 @@ int eth_header_cache(const struct neighbour *neigh, struct hh_cache *hh,
>                      __be16 type);
>  void eth_header_cache_update(struct hh_cache *hh, const struct net_device *dev,
>                              const unsigned char *haddr);
> +__be16 eth_header_parse_protocol(const struct sk_buff *skb);

Does not need to be exposed in the header file or exported.