netdev - Re: [PATCH bpf-next v2 08/16] bpf: functional and min/max reasoning unit tests for JMP32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87imyfa1ma.fsf@netronome.com>
Date:   Wed, 23 Jan 2019 14:29:33 +0000
From:   Jiong Wang <jiong.wang@...ronome.com>
To:     Jiong Wang <jiong.wang@...ronome.com>
Cc:     ast@...nel.org, daniel@...earbox.net, netdev@...r.kernel.org,
        oss-drivers@...ronome.com
Subject: Re: [PATCH bpf-next v2 08/16] bpf: functional and min/max reasoning unit tests for JMP32


Jiong Wang writes:

<snip>
> +/* BPF_RAND_SEXT_R7 contains 5 instructions, it initializes R7 into a random
> + * negative u32, and sign-extend it into 64-bit.
> + */
> +#define BPF_RAND_SEXT_R7						\
> +	BPF_RAW_INSN(BPF_JMP | BPF_CALL, 0, 0, 0,			\
> +		     BPF_FUNC_get_prandom_u32),				\
> +	BPF_MOV64_REG(BPF_REG_7, BPF_REG_0),				\
> +	BPF_ALU64_IMM(BPF_OR, BPF_REG_7, 0x80000000)			\
                                                    ^~~~ ',' missing
> +	BPF_ALU64_IMM(BPF_LSH, BPF_REG_7, 32),				\
> +	BPF_ALU64_IMM(BPF_ARSH, BPF_REG_7, 32),
                                              ^~~~ ',' should be removed

Apology, just found there is a minor fix on testcase that I forget to
commit before generating patch set. One ',' is missing and one ',' should
be removed as described above.

I will correct this in v3 together with other reviews if any.

Regards,
Jiong