lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <a206de4d-60bb-e2d8-9bf6-65b081effb62@cogentembedded.com> Date: Wed, 23 Jan 2019 18:01:57 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Simon Horman <horms+renesas@...ge.net.au>, David Miller <davem@...emloft.net> Cc: Magnus Damm <magnus.damm@...il.com>, netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org Subject: Re: [PATCH v2 net] ravb: expand rx descriptor data to accommodate hw checksum On 01/23/2019 02:14 PM, Simon Horman wrote: > EtherAVB may provide a checksum of packet data appended to packet data. In > order to allow this checksum to be received by the host descriptor data > needs to be enlarged by 2 bytes to accommodate the checksum. > > In the case of MTU-sized packets without a VLAN tag the > checksum were already accommodated by virtue of the space reserved for the > VLAN tag. However, a packet of MTU-size with a VLAN tag consumed all > packet data space provided by a descriptor leaving no space for the > trailing checksum. > > This was not detected by the driver which incorrectly used the last two > bytes of packet data as the checksum and truncate the packet by two bytes. > This resulted all such packets being dropped. > > A work around is to disable RX checksum offload > # ethtool -K eth0 rx off > > This patch resolves this problem by increasing the size available for > packet data in RX descriptors by two bytes. > > Tested on R-Car E3 (r8a77990) ES1.0 based Ebisu-4D board > > v2 > * Use sizeof(__sum16) directly rather than adding a driver-local > #define for the size of the checksum provided by the hw (2 bytes). > > Fixes: 4d86d3818627 ("ravb: RX checksum offload") > Signed-off-by: Simon Horman <horms+renesas@...ge.net.au> Reviewed-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> [...] MBR, Sergei
Powered by blists - more mailing lists