netdev - Re: [PATCH iproute2-next] Introduce ip-brctl shell script

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJieiUhEzff7ukTpoch5bRkL-9Rc5pe1PibNjRcqput7JxFOWQ@mail.gmail.com>
Date:   Wed, 23 Jan 2019 08:33:27 -0800
From:   Roopa Prabhu <roopa@...ulusnetworks.com>
To:     Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Cc:     Stefano Brivio <sbrivio@...hat.com>,
        David Ahern <dsahern@...il.com>, Phil Sutter <phil@....cc>,
        Eric Garver <egarver@...hat.com>,
        Tomas Dolezal <todoleza@...hat.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Lennert Buytenhek <buytenh@....org>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2-next] Introduce ip-brctl shell script

On Wed, Jan 23, 2019 at 7:09 AM Nikolay Aleksandrov
<nikolay@...ulusnetworks.com> wrote:
>
> On 18/01/2019 19:00, Stefano Brivio wrote:
> > This script wraps 'ip' and 'bridge' tools to provide a drop-in replacement
> > of the standalone 'brctl' utility.
> >
> > It's bug-to-bug compatible with brctl as of bridge-utils version 1.6,
> > has no dependencies other than a POSIX shell, and it's less than half
> > the binary size of brctl on x86_64.
> >
> > As many users (including myself) seem to find brctl usage vastly more
> > intuitive than ip-link, possibly due to habit, this might be a lightweight
> > approach to provide brctl syntax without the need to maintain bridge-utils
> > any longer.
> >
> > Signed-off-by: Stefano Brivio <sbrivio@...hat.com>
> > Acked-by: Phil Sutter <phil@....cc>
> > ---
> >  man/man8/Makefile   |   5 +-
> >  man/man8/ip-brctl.8 | 187 +++++++++++++++
> >  misc/Makefile       |   9 +-
> >  misc/ip-brctl.in    | 572 ++++++++++++++++++++++++++++++++++++++++++++
> >  4 files changed, 770 insertions(+), 3 deletions(-)
> >  create mode 100644 man/man8/ip-brctl.8
> >  create mode 100755 misc/ip-brctl.in
>
> Hi,
> IMO the effort should be towards improving iproute2 to be
> easier to use and more intuitive. We should be pushing people to use the new tools
> instead of trying to find workarounds to keep the old tools alive.
> I do like to idea of deprecating bridge-utils, but I think it should be done
> via improving ip/bridge enough to be pleasant to use. We will have to
> maintain this compatibility layer forever if it gets accepted and we'll never
> get rid of brctl this way.
>

+1, we should move people away from brtcl. there is enough confusion
among users looking at bridge attributes.,

ip -d link show
bridge -d link show
brctl

Adding a 4th one  to the list is not going to ease the confusion. We
should try to make the 'ip -d link show and bridge -d link show'
outputs better. Any suggestions there from people will be useful.