netdev - Re: [PATCH net-next] intel: Mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <368769c1-bb6c-b137-14c4-ef0ade488c2e@embeddedor.com>
Date:   Wed, 23 Jan 2019 11:11:39 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     jeffrey.t.kirsher@...el.com,
        "David S. Miller" <davem@...emloft.net>
Cc:     intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] intel: Mark expected switch fall-throughs

Hi Jeffrey,

On 1/23/19 11:04 AM, Jeff Kirsher wrote:
> On Wed, 2019-01-23 at 01:48 -0600, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> This patch fixes the following warnings:
>>
>> drivers/net/ethernet/intel/igb/e1000_82575.c:636:6: warning: this
>> statement may fall through [-Wimplicit-fallthrough=]
>> drivers/net/ethernet/intel/igb/igb_main.c:6710:6: warning: this
>> statement may fall through [-Wimplicit-fallthrough=]
>> drivers/net/ethernet/intel/i40e/i40e_xsk.c:237:3: warning: this
>> statement may fall through [-Wimplicit-fallthrough=]
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enabling
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
>> ---
>>  drivers/net/ethernet/intel/i40e/i40e_xsk.c   | 3 ++-
>>  drivers/net/ethernet/intel/igb/e1000_82575.c | 2 +-
>>  drivers/net/ethernet/intel/igb/igb_main.c    | 2 +-
>>  3 files changed, 4 insertions(+), 3 deletions(-)
> 
> NAK on the igb changes.  There is already a "fall through" code comment
> which is fine, adding a hyphen does not make the comment any more
> readable.
> 

Those comments are not fine. They trigger the warnings I mention in the
commit log. With this patch such warnings are fixed.

Notice that warning level 3 was used: -Wimplicit-fallthrough=3

Thanks
--
Gustavo