lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1548209986-83527-12-git-send-email-maowenan@huawei.com> Date: Wed, 23 Jan 2019 10:19:46 +0800 From: Mao Wenan <maowenan@...wei.com> To: <netdev@...r.kernel.org>, <gregkh@...ux-foundation.org>, <eric.dumazet@...il.com>, <davem@...emloft.net>, <stable@...r.kernel.org>, <edumazet@...gle.com> Subject: [PATCH stable 4.4 11/11] ipv4: frags: precedence bug in ip_expire() From: Dan Carpenter <dan.carpenter@...cle.com> [ Upstream commit 70837ffe3085c9a91488b52ca13ac84424da1042 ] We accidentally removed the parentheses here, but they are required because '!' has higher precedence than '&'. Fixes: fa0f527358bd ("ip: use rb trees for IP frag queue.") Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> Signed-off-by: David S. Miller <davem@...emloft.net> Signed-off-by: Mao Wenan <maowenan@...wei.com> --- net/ipv4/ip_fragment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/ip_fragment.c b/net/ipv4/ip_fragment.c index 0e75881..eb8955c 100644 --- a/net/ipv4/ip_fragment.c +++ b/net/ipv4/ip_fragment.c @@ -257,7 +257,7 @@ static void ip_expire(unsigned long arg) IP_INC_STATS_BH(net, IPSTATS_MIB_REASMFAILS); IP_INC_STATS_BH(net, IPSTATS_MIB_REASMTIMEOUT); - if (!qp->q.flags & INET_FRAG_FIRST_IN) + if (!(qp->q.flags & INET_FRAG_FIRST_IN)) goto out; /* sk_buff::dev and sk_buff::rbnode are unionized. So we -- 1.8.3.1
Powered by blists - more mailing lists