netdev - Re: [PATCH net-next] r8169: improve firmware handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190123.112428.1341100564264047927.davem@davemloft.net>
Date:   Wed, 23 Jan 2019 11:24:28 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     nic_swsd@...ltek.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] r8169: improve firmware handling

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Tue, 22 Jan 2019 22:23:41 +0100

> So far member rtl_fw has three states:
> - IS_ERR(rtl_fw): firmware not loaded
> - !rtl_fw: no firmware available
> - other: firmware loaded
> 
> This can be made simpler and clearer by adding the firmware name as
> member fw_name to struct rtl8169_private. Then:
> 
> - !fw_name: no firmware available
> - !rtl_fw: firmware not loaded
> - rtl_fw: firmware loaded
> 
> This change also allows to easily merge rtl_request_uncached_firmware
> into rtl_request_firmware.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied.