lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190124094706.57050b51@shemminger-XPS-13-9360> Date: Thu, 24 Jan 2019 09:47:06 +1300 From: Stephen Hemminger <stephen@...workplumber.org> To: Cong Wang <xiyou.wangcong@...il.com> Cc: netdev@...r.kernel.org, Martin Olsson <martin.olsson+netdev@...torsecurity.com>, Jamal Hadi Salim <jhs@...atatu.com>, Jiri Pirko <jiri@...nulli.us>, David Ahern <dsahern@...il.com> Subject: Re: [Patch iproute2] tc: add hit counter for matchall On Thu, 17 Jan 2019 13:18:55 -0800 Cong Wang <xiyou.wangcong@...il.com> wrote: > > + if (tb[TCA_MATCHALL_PCNT]) { > + if (RTA_PAYLOAD(tb[TCA_MATCHALL_PCNT]) < sizeof(*pf)) { > + print_string(PRINT_FP, NULL, "Broken perf counters\n", NULL); This the wrong way to print an error message with iproute2 suite. The correct answer is simple. fprintf(stderr, "Broken perf counters\n"); and better yet give a more informative message that says what is incorrect.
Powered by blists - more mailing lists