netdev - Re: [PATCH] devlink: Use DIV_ROUND_UP_ULL in DEVLINK_HEALTH_SIZE_TO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190122.210049.740424638207753657.davem@davemloft.net>
Date:   Tue, 22 Jan 2019 21:00:49 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     natechancellor@...il.com
Cc:     jiri@...lanox.com, eranbe@...lanox.com, moshe@...lanox.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] devlink: Use DIV_ROUND_UP_ULL in
 DEVLINK_HEALTH_SIZE_TO_BUFFERS

From: Nathan Chancellor <natechancellor@...il.com>
Date: Mon, 21 Jan 2019 21:23:01 -0700

> When building this code on a 32-bit platform such as ARM, there is a
> link time error (lld error shown, happpens with ld.bfd too):
> 
> ld.lld: error: undefined symbol: __aeabi_uldivmod
>>>> referenced by devlink.c
>>>>               net/core/devlink.o:(devlink_health_buffers_create) in archive built-in.a
> 
> This happens when using a regular division symbol with a u64 dividend.
> Use DIV_ROUND_UP_ULL, which wraps do_div, to avoid this situation.
> 
> Fixes: cb5ccfbe73b3 ("devlink: Add health buffer support")
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

Applied to net-next.