netdev - Re: [PATCH net 5/5] net: aquantia: added err var into AQ_HW_WAIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 24 Jan 2019 14:28:10 +0000
From:   Igor Russkikh <Igor.Russkikh@...antia.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "David S . Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Nikita Danilov <Nikita.Danilov@...antia.com>
Subject: Re: [PATCH net 5/5] net: aquantia: added err var into AQ_HW_WAIT_FOR
 construct



> You can define a little helper:
> 
> static u32 aq_hw_read_mpi_state2_addr(struct aq_hw_s *self)
> {
> 	return aq_hw_read_reg(self, HW_ATL_FW2X_MPI_STATE2_ADDR);
> }
> 
> Then
> 
> 	readx_poll_timeout(u32 aq_hw_read_mpi_state2_addr, self,
> 			   stats_val, orig_stats_val != stats_val & BIT(CAPS_HI_STATISTICS));
> 

[cut]

> You see this sort of construct in quite a lot of drivers.


Thanks, Andrew,

Think that way this'll be the optimal case with best readability.

We'll update the patch.

Regards, Igor