netdev - Re: [PATCH] tipc: remove dead code in struct tipc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b419877d-49cb-15c6-7546-7b23a30631e3@windriver.com>
Date:   Thu, 24 Jan 2019 10:40:18 +0800
From:   Ying Xue <ying.xue@...driver.com>
To:     Zhaolong Zhang <zhangzl2013@....com>, <jon.maloy@...csson.com>,
        <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <tipc-discussion@...ts.sourceforge.net>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tipc: remove dead code in struct tipc_topsrv

On 1/24/19 10:06 AM, Zhaolong Zhang wrote:
> max_rcvbuf_size is no longer used since commit "414574a0af36".
> 
> Signed-off-by: Zhaolong Zhang <zhangzl2013@....com>

Acked-by: Ying Xue <ying.xue@...driver.com>

> ---
>  net/tipc/topsrv.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/net/tipc/topsrv.c b/net/tipc/topsrv.c
> index efb16f6..4b1c083 100644
> --- a/net/tipc/topsrv.c
> +++ b/net/tipc/topsrv.c
> @@ -60,7 +60,6 @@
>   * @awork: accept work item
>   * @rcv_wq: receive workqueue
>   * @send_wq: send workqueue
> - * @max_rcvbuf_size: maximum permitted receive message length
>   * @listener: topsrv listener socket
>   * @name: server name
>   */
> @@ -72,7 +71,6 @@ struct tipc_topsrv {
>  	struct work_struct awork;
>  	struct workqueue_struct *rcv_wq;
>  	struct workqueue_struct *send_wq;
> -	int max_rcvbuf_size;
>  	struct socket *listener;
>  	char name[TIPC_SERVER_NAME_LEN];
>  };
> @@ -648,7 +646,6 @@ int tipc_topsrv_start(struct net *net)
>  		return -ENOMEM;
>  
>  	srv->net = net;
> -	srv->max_rcvbuf_size = sizeof(struct tipc_subscr);
>  	INIT_WORK(&srv->awork, tipc_topsrv_accept);
>  
>  	strscpy(srv->name, name, sizeof(srv->name));
>