lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 24 Jan 2019 19:07:24 +0100 From: Mathieu Malaterre <malat@...ian.org> To: Marcel Holtmann <marcel@...tmann.org> Cc: Mathieu Malaterre <malat@...ian.org>, Peter Hurley <peter@...leysoftware.com>, Johan Hedberg <johan.hedberg@...il.com>, "David S. Miller" <davem@...emloft.net>, linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH 2/2] Bluetooth: Correctly annotate implicit fall through in __rfcomm_dlc_close There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1). In this particular case put the fall through comment on a separate line so as to match the regular expression expected by GCC. This commit removes the following warning: net/bluetooth/rfcomm/core.c:479:6: warning: this statement may fall through [-Wimplicit-fallthrough=] Cc: Peter Hurley <peter@...leysoftware.com> Signed-off-by: Mathieu Malaterre <malat@...ian.org> --- net/bluetooth/rfcomm/core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/bluetooth/rfcomm/core.c b/net/bluetooth/rfcomm/core.c index 1a635df80643..caaae6accafa 100644 --- a/net/bluetooth/rfcomm/core.c +++ b/net/bluetooth/rfcomm/core.c @@ -480,9 +480,8 @@ static int __rfcomm_dlc_close(struct rfcomm_dlc *d, int err) __rfcomm_dlc_disconn(d); break; } - /* if closing a dlc in a session that hasn't been started, - * just close and unlink the dlc - */ + /* fall through - if closing a dlc in a session that hasn't */ + /* been started, just close and unlink the dlc */ default: rfcomm_dlc_clear_timer(d); -- 2.19.2
Powered by blists - more mailing lists