netdev - Re: [Patch iproute2] tc: add performance counters for basic filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpW6X=w6orNcWdXrTmOaNtRwJ4QvhHeQH6UvAEDNEoUnmg@mail.gmail.com>
Date:   Wed, 23 Jan 2019 17:14:22 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>, David Ahern <dsahern@...il.com>
Subject: Re: [Patch iproute2] tc: add performance counters for basic filter

On Wed, Jan 23, 2019 at 12:43 PM Stephen Hemminger
<stephen@...workplumber.org> wrote:
>
> On Tue, 22 Jan 2019 22:41:45 -0800
> Cong Wang <xiyou.wangcong@...il.com> wrote:
>
> > +     if (tb[TCA_BASIC_PCNT]) {
> > +             if (RTA_PAYLOAD(tb[TCA_BASIC_PCNT])  < sizeof(*pf)) {
> > +                     fprintf(f, "Broken perf counters\n");
> > +                     return -1;
>
> Errors should go to stderr not f (which is stdout).

Ok, I copy the code from u32 filter, so it has the same issue.