netdev - Re: [PATCH v2 bpf-next] bpf: use the proper optlen when doing strncpy in bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9645e625-e090-2fa4-b570-0862ddfc5b19@iogearbox.net>
Date:   Thu, 24 Jan 2019 12:24:43 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Yafang Shao <laoar.shao@...il.com>, kafai@...com, brakmo@...com,
        ast@...nel.org
Cc:     netdev@...r.kernel.org, shaoyafang@...iglobal.com
Subject: Re: [PATCH v2 bpf-next] bpf: use the proper optlen when doing strncpy
 in bpf_getsockopt()

On 01/24/2019 06:16 AM, Yafang Shao wrote:
> As strncpy(..., TCP_CA_NAME_MAX-1) is used in bpf_setsockopt(),
> this change  will make it more consistent with the bpf_setsockopt() above.
> 
> Acked-by: Martin KaFai Lau <kafai@...com>
> Acked-by: Lawrence Brakmo <brakmo@...com>
> Signed-off-by: Yafang Shao <laoar.shao@...il.com>

While not wrong, I also don't think it improves much either. As mentioned,
that code is totally fine as it currently is.