netdev - Re: [PATCH bpf-next v2 2/8] libbpf: Add a helper for retrieving a prog via index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190124130949.1bfbbf15@redhat.com>
Date:   Thu, 24 Jan 2019 13:09:49 +0100
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     Maciej Fijalkowski <maciejromanfijalkowski@...il.com>,
        ast@...nel.org, netdev@...r.kernel.org,
        jakub.kicinski@...ronome.com, brouer@...hat.com
Subject: Re: [PATCH bpf-next v2 2/8] libbpf: Add a helper for retrieving a
 prog via index

On Thu, 24 Jan 2019 12:56:36 +0100
Daniel Borkmann <daniel@...earbox.net> wrote:

> > Please feel free to deprecate or remove the xdp_redirect_cpu --prognum
> > option.  I would prefer if this was indeed converted to selecting the
> > program based on the name in the _kern.c file, instead of a number.  
> 
> Given this is BPF sample code, there is no need to deprecate, lets just
> remove --prognum option and add a new one for selection by name.

I agree, just remove  --prognum option.

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer