netdev - Re: [PATCH] Bluetooth: make hw_err static, reduces object code size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 Jan 2019 08:54:39 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: make hw_err static, reduces object code size

Hi Colin,

> Don't populate the const array hw_err on the stack but instead make
> it static. Makes the object code smaller by 45 bytes:
> 
> Before:
>   text	   data	    bss	    dec	    hex	filename
> 100880	  21090	   1088	 123058	  1e0b2	linux/net/bluetooth/hci_core.o
> 
> After:
>   text	   data	    bss	    dec	    hex	filename
> 100739	  21186	   1088	 123013	  1e085	linux/net/bluetooth/hci_core.o
> 
> (gcc version 8.2.0 x86_64)
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
> net/bluetooth/hci_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel