netdev - Re: [PATCH bpf-next 2/6] samples: bpf: Convert XDP samples to libbpf usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190125092200.62fee303@redhat.com>
Date:   Fri, 25 Jan 2019 09:22:00 +0100
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Maciej Fijalkowski <maciejromanfijalkowski@...il.com>
Cc:     daniel@...earbox.net, ast@...nel.org, netdev@...r.kernel.org,
        jakub.kicinski@...ronome.com, brouer@...hat.com
Subject: Re: [PATCH bpf-next 2/6] samples: bpf: Convert XDP samples to
 libbpf usage

On Thu, 17 Jan 2019 02:01:11 +0100
Maciej Fijalkowski <maciejromanfijalkowski@...il.com> wrote:

> Some of XDP samples that are attaching the bpf program to the interface
> via libbpf's bpf_set_link_xdp_fd are still using the bpf_load.c for
> loading and manipulating the ebpf program and maps. Convert them to do
> this through libbpf usage and remove bpf_load from the picture.
> 
> While at it remove what looks like debug leftover in
> xdp_redirect_map_user.c
> 
> xdp_redirect_cpu is omitted because of read_trace_pipe() usage, which
> doesn't seem to be handled in libbpf ATM.
> 
> Signed-off-by: Maciej Fijalkowski <maciejromanfijalkowski@...il.com>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> ---
>  samples/bpf/Makefile                |  8 ++--
>  samples/bpf/xdp_redirect_map_user.c | 47 ++++++++++++++++-------
>  samples/bpf/xdp_redirect_user.c     | 44 +++++++++++++++++-----
>  samples/bpf/xdp_router_ipv4_user.c  | 75 ++++++++++++++++++++++++++-----------
>  samples/bpf/xdp_tx_iptunnel_user.c  | 37 ++++++++++++------
>  5 files changed, 151 insertions(+), 60 deletions(-)

Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>

Thanks a lot for converting sample/bpf programs to use libbpf.  It have
been on my todo list for a very long time.

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer