netdev - Re: [PATCH net-next v3 2/2] net/mlx5e: Don't overwrite pedit action when multiple pedit used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ3xEMjEndp3GspByi4zr-wTcfOH-YXRgas8WOfQY=H6rwrHiQ@mail.gmail.com>
Date:   Fri, 25 Jan 2019 23:57:46 +0200
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     Tonghao Zhang <xiangxia.m.yue@...il.com>
Cc:     Saeed Mahameed <saeedm@...lanox.com>,
        Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v3 2/2] net/mlx5e: Don't overwrite pedit action
 when multiple pedit used

On Tue, Jan 22, 2019 at 4:38 PM <xiangxia.m.yue@...il.com> wrote:
> From: Tonghao Zhang <xiangxia.m.yue@...il.com>
>
> In some case, we may use multiple pedit actions to modify packets.

just to clarify, this is a matter of choice, right? in other words, it
doesn't buy you extra functionality

> The command shown as below: the last pedit action is effective.

and we are leaking some memory / HW (modify header instance) objects
in the driver, as of that, right? this makes your patch a fix which
should be labeled
by "net" and not "net-next", same goes to the neigh update fix, would be good
if you repost them with net labeling.