lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a588ab43-a61b-7106-589b-b3d6c92f42b4@iogearbox.net>
Date:   Fri, 25 Jan 2019 23:10:51 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Jesper Dangaard Brouer <brouer@...hat.com>, netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Daniel Borkmann <borkmann@...earbox.net>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>
Subject: Re: [net-next PATCH] MAINTAINERS: Add entry for XDP core code

Hi Jesper,

On 01/25/2019 01:02 PM, Jesper Dangaard Brouer wrote:
> Add myself as a maintainer for these parts, as I'm responsible
> for adding most of this.
> 
> Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>
> ---
>  MAINTAINERS |    9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a0245fd1b09a..f66297853df7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16686,6 +16686,15 @@ T:	git git://linuxtv.org/media_tree.git
>  S:	Maintained
>  F:	drivers/media/tuners/tuner-xc2028.*
>  
> +XDP

Hm, I think this may be a bit misleading, XDP 'core' bits that are
needed for XDP base operation are spread into many more places than
just the ones listed below like net/core/dev.c, net/core/rtnetlink.c,
net/core/filter.c to name a few, then obviously drivers themselves,
and also there's net/xdp/ etc. Depending on what you mean, it might
make it probably more clear to split this into specific sub-topics
like below XDP SOCKETS, e.g. XDP CPUMAP, XDP PAGE POOL or such for
expert review, or if this should be some sort of catch-all (?)
underneath general networking entry, then this should more accurately
reflect core code so reviewers are properly Cc'ed on all the pieces
if someone runs get_maintainer.pl to get a Cc list ... maybe also
makes sense to add other XDP contributors as well.

> +M:	Jesper Dangaard Brouer <hawk@...nel.org>
> +L:	netdev@...r.kernel.org
> +L:	xdp-newbies@...r.kernel.org
> +F:	net/core/xdp.c
> +F:	include/net/xdp.h
> +F:	kernel/bpf/devmap.c
> +F:	kernel/bpf/cpumap.c
> +
>  XDP SOCKETS (AF_XDP)
>  M:	Björn Töpel <bjorn.topel@...el.com>
>  M:	Magnus Karlsson <magnus.karlsson@...el.com>
> 

Cheers,
Daniel

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ