netdev - Re: [PATCH -next] selftests: bpf: remove duplicated include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 25 Jan 2019 15:01:02 -0800
From:   Song Liu <liu.song.a23@...il.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, shuah@...nel.org,
        open list <linux-kernel@...r.kernel.org>,
        linux-kselftest@...r.kernel.org,
        Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH -next] selftests: bpf: remove duplicated include

On Thu, Jan 24, 2019 at 6:49 PM YueHaibing <yuehaibing@...wei.com> wrote:
>
> Remove duplicated include.
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Acked-by: Song Liu <songliubraving@...com>

Thanks!

> ---
>  tools/testing/selftests/bpf/test_flow_dissector.c | 2 --
>  tools/testing/selftests/bpf/test_maps.c           | 1 -
>  tools/testing/selftests/bpf/test_sockmap.c        | 1 -
>  3 files changed, 4 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/test_flow_dissector.c b/tools/testing/selftests/bpf/test_flow_dissector.c
> index 12b784a..01f0c63 100644
> --- a/tools/testing/selftests/bpf/test_flow_dissector.c
> +++ b/tools/testing/selftests/bpf/test_flow_dissector.c
> @@ -16,7 +16,6 @@
>  #include <errno.h>
>  #include <linux/if_packet.h>
>  #include <linux/if_ether.h>
> -#include <linux/if_packet.h>
>  #include <linux/ipv6.h>
>  #include <netinet/ip.h>
>  #include <netinet/in.h>
> @@ -25,7 +24,6 @@
>  #include <stdbool.h>
>  #include <stdlib.h>
>  #include <stdio.h>
> -#include <stdlib.h>
>  #include <string.h>
>  #include <sys/ioctl.h>
>  #include <sys/socket.h>
> diff --git a/tools/testing/selftests/bpf/test_maps.c b/tools/testing/selftests/bpf/test_maps.c
> index e2b9eee..1dfef77 100644
> --- a/tools/testing/selftests/bpf/test_maps.c
> +++ b/tools/testing/selftests/bpf/test_maps.c
> @@ -633,7 +633,6 @@ static void test_stackmap(int task, void *data)
>         close(fd);
>  }
>
> -#include <sys/socket.h>
>  #include <sys/ioctl.h>
>  #include <arpa/inet.h>
>  #include <sys/select.h>
> diff --git a/tools/testing/selftests/bpf/test_sockmap.c b/tools/testing/selftests/bpf/test_sockmap.c
> index e85a771..3845144 100644
> --- a/tools/testing/selftests/bpf/test_sockmap.c
> +++ b/tools/testing/selftests/bpf/test_sockmap.c
> @@ -10,7 +10,6 @@
>  #include <unistd.h>
>  #include <string.h>
>  #include <errno.h>
> -#include <sys/ioctl.h>
>  #include <stdbool.h>
>  #include <signal.h>
>  #include <fcntl.h>
> --
> 2.7.0
>
>