netdev - Re: [PATCH net] sctp: improve the events for sctp stream reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190124.182506.271204705053172488.davem@davemloft.net>
Date:   Thu, 24 Jan 2019 18:25:06 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        linux-sctp@...r.kernel.org, marcelo.leitner@...il.com,
        nhorman@...driver.com
Subject: Re: [PATCH net] sctp: improve the events for sctp stream reset

From: Xin Long <lucien.xin@...il.com>
Date: Tue, 22 Jan 2019 02:39:34 +0800

> This patch is to improve sctp stream reset events in 4 places:
> 
>   1. In sctp_process_strreset_outreq(), the flag should always be set with
>      SCTP_STREAM_RESET_INCOMING_SSN instead of OUTGOING, as receiver's in
>      stream is reset here.
>   2. In sctp_process_strreset_outreq(), move up SCTP_STRRESET_ERR_WRONG_SSN
>      check, as the reset has to succeed after reconf_timer stops for the
>      in stream reset request retransmission.
>   3. In sctp_process_strreset_inreq(), no event should be sent, as no in
>      or out stream is reset here.
>   4. In sctp_process_strreset_resp(), SCTP_STREAM_RESET_INCOMING_SSN or
>      OUTGOING event should always be sent for stream reset requests, no
>      matter it fails or succeeds to process the request.
> 
> Fixes: 810544764536 ("sctp: implement receiver-side procedures for the Outgoing SSN Reset Request Parameter")
> Fixes: 16e1a91965b0 ("sctp: implement receiver-side procedures for the Incoming SSN Reset Request Parameter")
> Fixes: 11ae76e67a17 ("sctp: implement receiver-side procedures for the Reconf Response Parameter")
> Reported-by: Ying Xu <yinxu@...hat.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied and queued up for -stable.