netdev - Re: WoL broken in r8169.c since kernel 4.19

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a17454a-3017-7283-89d6-206681ca4c47@gmail.com>
Date:   Sat, 26 Jan 2019 15:04:34 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Marc Haber <mh+netdev@...schlus.de>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: WoL broken in r8169.c since kernel 4.19

On 26.01.2019 14:56, Marc Haber wrote:
> On Fri, Jan 25, 2019 at 07:22:36PM +0100, Heiner Kallweit wrote:
>> Then I'm slowly running out of ideas. New in 4.19 is a check for invalid
>> WoL flags, but usually the caller should warn if -EINVAL is returned.
>> Nevertheless, could you try the following and check whether the warning
>> is triggered?
> 
> Compiled the kernel, went through the motions:
> 
> - boot
> - suspend
> - try unsuccessful WoL
> - wake up manually
> - do ethtool gymnastics
> - suspend
> - try successful WoL
> - grep syslog for "WoL", nothing found.
> 
Thanks for testing. Then the only way to find the offending commit is bisecting.
Let me know if you need support.

I can't reproduce the issue on latest kernels even though RTL8168evl and RTL8168g
use the same WoL code path.

> Greetings
> Marc
> 
Heiner