Message-ID: <2b1f324a-8ace-f03c-b8d1-2358a5bb3a11@gmail.com>
Date:   Sat, 26 Jan 2019 15:09:48 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Marc Haber <mh+netdev@...schlus.de>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: WoL broken in r8169.c since kernel 4.19

On 26.01.2019 15:08, Heiner Kallweit wrote:
> On 13.01.2019 17:01, Marc Haber wrote:
>> On Sat, Jan 12, 2019 at 09:28:48PM +0100, Heiner Kallweit wrote:
>>> On 12.01.2019 21:08, Marc Haber wrote:
>>>> I am writing to all people who have commits in r8169.c between the v4.18
>>>> and v4.19 tags in the Linux kernel. Please ignore as appropriate. If
>>>> you'd prefer that to be on a mailing list, please indicate on which list
>>>> you want to have that, and I'll resend.
>>>>
>>> It should be cc'ed to the netdev mailing list, as listed in MAINTAINERS.
>>
>> I have bounced the original message there. Sorry for missing that, I was
>> not aware that the MAINTAINERS file goes down on a single driver level.
>>
>>>> My desktop copmuter has the following network interface:
>>>>
>>>> 06:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller (rev 06)
>>>>         Subsystem: ASUSTeK Computer Inc. P8P67 and other motherboards
>>>>         Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx+
>>>>         Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
>>>>         Latency: 0, Cache Line Size: 64 bytes
>>>>         Interrupt: pin A routed to IRQ 17
>>>>         NUMA node: 0
>>>>         Region 0: I/O ports at e800 [size=256]
>>>>         Region 2: Memory at fdfff000 (64-bit, prefetchable) [size=4K]
>>>>         Region 4: Memory at fdff8000 (64-bit, prefetchable) [size=16K]
>>>>         Capabilities: <access denied>
>>>>         Kernel driver in use: r8169
>>>>         Kernel modules: r8169
>>>>
>>> Unfortunately there's different chip versions with the same description.
>>> Please provide the result of "dmesg | grep XID".
>>
>> [1/5004]mh@fan:~ $ dmesg | grep XID
>> [    2.671004] r8169 0000:06:00.0 eth0: RTL8168evl/8111evl, 54:04:a6:82:21:00, XID 2c900800, IRQ 29
>>
>>>> I regularly buíld a VPN tunnel to my local network from 'on the road'
>>>> and use WoL to wake up the desktop box when I need it.
>>>>
>>>> Since kernel 4.19, that does not work any more, the desktop remains
>>>> suspended when I send it a magic packet. This still applies to 4.20.1,
>>>> and it still works with any 4.18 kernel.
>>>>
>>> WoL works perfectly fine here with r8169 from runtime-suspend and
>>> from S3. How do you enable WoL? And which WoL method do you use
>>> (magic packet or ..) ?
>>
>> I do enable WOL via systemd-networkd:
>> [7/5009]mh@fan:~ $ cat /etc/systemd/network/10-lanc0.link
>> [Match]
>> MACAddress=54:04:a6:82:21:00
>>
>> [Link]
>> Name=lanc0
>> WakeOnLan=magic
>>
>> and I wake up the box by calling
>>
>> sudo etherwake -i int182 54:04:a6:82:21:00
>>
>> on the router. int182 is the interface name of the correct interface,
>> this is proven correct by the fact that the box wakes up just fine with
>> older version of the driver.
>>
>>> Please provide a register dump (ethtool -d <if>).
>>
>> The register dump is here (obtained with 4.20.1 with the r8169.c from
>> 4.18):
>> [5/5008]mh@fan:~ $ sudo ethtool -d lanc0
> 
> Just one more thing because this register dump was with the r8169 driver
> from 4.18 which is known to work.
> Can you provide a register dump from a 4.20 r8169 which suffers from the issue?
> 
Sorry, just saw that you did so already.

Powered by blists - more mailing lists