netdev - Re: WoL broken in r8169.c since kernel 4.19

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64b22f62-ca8a-caee-5a39-f06ffe6598d1@gmail.com>
Date:   Sun, 27 Jan 2019 22:09:51 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Marc Haber <mh+netdev@...schlus.de>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: WoL broken in r8169.c since kernel 4.19

On 27.01.2019 21:55, Marc Haber wrote:
> On Sat, Jan 26, 2019 at 08:22:33PM +0100, Heiner Kallweit wrote:
>> You could go with this range:
>> from 4ff364662814 ("r8169: replace get_protocol with vlan_get_protocol")
>> to 649f0837a8cc ("r8169: fix broken Wake-on-LAN from S5 (poweroff)")
> 
> I am quite inexperienced with bisecting and am therefore giving a better
> account of my actions here.
> 
> [2/4994]mh@fan:~/linux/git/linux ((v4.18.16) %) $ git pull
> remote: Counting objects: 786, done.
> remote: Compressing objects: 100% (197/197), done.
> remote: Total 786 (delta 659), reused 697 (delta 589)
> Receiving objects: 100% (786/786), 146.00 KiB | 1.20 MiB/s, done.
> Resolving deltas: 100% (659/659), completed with 237 local objects.
>>>From git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux
>    ba6069759381..1fc7f56db7a7  master     -> origin/master
> You are not currently on a branch.
> 1 [3/4995]mh@fan:~/linux/git/linux ((v4.18.16) %) $ git checkout 4ff364662814
> Checking out files: 100% (13994/13994), done.
> Previous HEAD position was 6b3252287aa2 Linux 4.18.16
> HEAD is now at 4ff364662814 r8169: replace get_protocol with vlan_get_protocol
> [4/4996]mh@fan:~/linux/git/linux ((4ff364662814...) %) $ git bisect start drivers/net/ethernet/realtek/r8169.c
> [5/4997]mh@fan:~/linux/git/linux ((4ff364662814...) %|BISECTING) $ 
> (copy 4.20 config, make oldconfig, say no to everything, make deb-pkg, install and try)
> this boots and wakes up on magic packet from suspend to ram
> [2/4994]mh@fan:~/linux/git/linux ((4ff364662814...) *%|BISECTING) $ git bisect good
> [3/4995]mh@fan:~/linux/git/linux ((4ff364662814...) *%|BISECTING) $ git checkout 649f0837a8cc
> Checking out files: 100% (21794/21794), done.
> M       scripts/package/Makefile
> Previous HEAD position was 4ff364662814 r8169: replace get_protocol with vlan_get_protocol
> HEAD is now at 649f0837a8cc r8169: fix broken Wake-on-LAN from S5 (poweroff)
> [4/4996]mh@fan:~/linux/git/linux ((649f0837a8cc...) *%|BISECTING) $ 
> (copy 4.20 config, make oldconfig, say no to everything, make deb-pkg, install and try)
> this boots and does not wake up from StR on magic packet, after 
> waking up with any key on the keyboard I had an amdgpu issue on the console
> and a dead console, but was able to ssh in and reboot.
> 
> [2/4994]mh@fan:~/linux/git/linux ((649f0837a8cc...) *%|BISECTING) $ git
> bisect bad
> Bisecting: 33 revisions left to test after this (roughly 5 steps)
> [098b01ad9837b4d4d0022f407300f069a999e55a] r8169: don't include asm
> headers directly
> [3/4995]mh@fan:~/linux/git/linux ((098b01ad9837...) *%|BISECTING) $ 
> 
> I think I am on the right way here, am I?
> 
> Greetings
> Marc
> 
Yes. All you have to do after each "git bisect good/bad" is build again,
test, and make current build as good or bad.