netdev - Re: [PATCH AUTOSEL 4.19 094/258] nfp: add locking around representor changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190128172143.GE3973@sasha-vm>
Date:   Mon, 28 Jan 2019 12:21:43 -0500
From:   Sasha Levin <sashal@...nel.org>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        "David S . Miller" <davem@...emloft.net>,
        oss-drivers@...ronome.com, netdev@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 4.19 094/258] nfp: add locking around representor
 changes

On Mon, Jan 28, 2019 at 08:28:25AM -0800, Jakub Kicinski wrote:
>On Mon, 28 Jan 2019 10:56:40 -0500, Sasha Levin wrote:
>> From: Jakub Kicinski <jakub.kicinski@...ronome.com>
>>
>> [ Upstream commit 71844fac1ed459024dd2a448d63d5b28b8c87daa ]
>>
>> Up until now we never needed to keep a networking locks around
>> representors accesses, we only accessed them when device was
>> reconfigured (under nfp pf->lock) or on fast path (under RCU).
>> Now we want to be able to iterate over all representors during
>> notifications, so make sure representor assignment is done
>> under RTNL lock.
>>
>> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
>> Reviewed-by: John Hurley <john.hurley@...ronome.com>
>> Signed-off-by: David S. Miller <davem@...emloft.net>
>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>
>Hi Sasha!
>
>There is no need for backporting this unless 51a6588e8c08 ("nfp: add
>offloads on representors") is also back ported (which is a feature).

I'll drop it. Thanks for the heads-up.

--
Thanks,
Sasha