netdev - Re: [PATCH net 0/4] various compat ioctl fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190128.112256.1993605129492088954.davem@davemloft.net>
Date:   Mon, 28 Jan 2019 11:22:56 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     johannes@...solutions.net
Cc:     netdev@...r.kernel.org, viro@...iv.linux.org.uk,
        robert@...llahan.org
Subject: Re: [PATCH net 0/4] various compat ioctl fixes

From: Johannes Berg <johannes@...solutions.net>
Date: Fri, 25 Jan 2019 22:43:16 +0100

> Back a long time ago, I already fixed a few of these by passing
> the size of the struct ifreq to do_sock_ioctl(). However, Robert
> found more cases, and now it won't be as simple because we'd have
> to pass that down all the way to e.g. bond_do_ioctl() which isn't
> really feasible.
> 
> Therefore, restore the old code.
> 
> While looking at why SIOCGIFNAME was broken, I realized that Al
> had removed that case - which had been handled in an explicit
> separate function - as well, and looking through his work at the
> time I saw that bond ioctls were also affected by the erroneous
> removal.
> 
> I've restored SIOCGIFNAME and bond ioctls by going through the
> (now renamed) dev_ifsioc() instead of reintroducing their own
> helper functions, which I hope is correct but have only tested
> with SIOCGIFNAME.

I see some back and forth between you and Al, where do we stand at
this point?

>From what I can see this looks like probably the simplest way to
fix this in net and -stable currently.

Please let me know.

Thanks.