netdev - Re: [PATCH bpf-next v4 2/7] samples/bpf: xdp_redirect_cpu have not need for read_trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <816ed0c1-3b83-91bd-a1f2-53ca9f5bf19d@gmail.com>
Date:   Mon, 28 Jan 2019 12:50:40 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Maciej Fijalkowski <maciejromanfijalkowski@...il.com>,
        daniel@...earbox.net, ast@...nel.org
Cc:     netdev@...r.kernel.org, jakub.kicinski@...ronome.com,
        brouer@...hat.com
Subject: Re: [PATCH bpf-next v4 2/7] samples/bpf: xdp_redirect_cpu have not
 need for read_trace_pipe

On 1/28/19 11:16 AM, Maciej Fijalkowski wrote:
> From: Jesper Dangaard Brouer <brouer@...hat.com>
> 
> The sample xdp_redirect_cpu is not using helper bpf_trace_printk.
> Thus it makes no sense that the --debug option us reading
> from /sys/kernel/debug/tracing/trace_pipe via read_trace_pipe.
> Simply remove it.
> 
> Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>

Acked-by: John Fastabend <john.fastabend@...il.com>