netdev - Re: [PATCH bpf-next v4 5/7] samples/bpf: Add a "force" flag to XDP samples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b37c52a3-dd03-745f-793d-1fdbb4e6840f@gmail.com>
Date:   Mon, 28 Jan 2019 12:57:22 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Maciej Fijalkowski <maciejromanfijalkowski@...il.com>,
        daniel@...earbox.net, ast@...nel.org
Cc:     netdev@...r.kernel.org, jakub.kicinski@...ronome.com,
        brouer@...hat.com
Subject: Re: [PATCH bpf-next v4 5/7] samples/bpf: Add a "force" flag to XDP
 samples

On 1/28/19 11:16 AM, Maciej Fijalkowski wrote:
> From: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> 
> Make xdp samples consistent with iproute2 behavior and set the
> XDP_FLAGS_UPDATE_IF_NOEXIST by default when setting the xdp program on
> interface. Provide an option for user to force the program loading,
> which as a result will not include the mentioned flag in
> bpf_set_link_xdp_fd call.
> 
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> ---

Patch is fine but I don't really know if being consistent with
iproute2 here gets us much. I guess if users find the "force"
behavior better for a sample that is OK though.

Acked-by: John Fastabend <john.fastabend@...il.com>