netdev - Re: [PATCH net] ip6mr: Fix notifiers call on mroute_clean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190127.231719.285504281465860129.davem@redhat.com>
Date:   Sun, 27 Jan 2019 23:17:19 -0800 (PST)
From:   David Miller <davem@...hat.com>
To:     nird@...lanox.com
Cc:     netdev@...r.kernel.org, nikolay@...ulusnetworks.com,
        mlxsw@...lanox.com
Subject: Re: [PATCH net] ip6mr: Fix notifiers call on mroute_clean_tables()

From: Nir Dotan <nird@...lanox.com>
Date: Sun, 27 Jan 2019 09:26:22 +0200

> When the MC route socket is closed, mroute_clean_tables() is called to
> cleanup existing routes. Mistakenly notifiers call was put on the cleanup
> of the unresolved MC route entries cache.
> In a case where the MC socket closes before an unresolved route expires,
> the notifier call leads to a crash, caused by the driver trying to
> increment a non initialized refcount_t object [1] and then when handling
> is done, to decrement it [2]. This was detected by a test recently added in
> commit 6d4efada3b82 ("selftests: forwarding: Add multicast routing test").
> 
> Fix that by putting notifiers call on the resolved entries traversal,
> instead of on the unresolved entries traversal.
 ...
> Fixes: 088aa3eec2ce ("ip6mr: Support fib notifications")
> Signed-off-by: Nir Dotan <nird@...lanox.com>
> Reviewed-by: Ido Schimmel <idosch@...lanox.com>

Applied and queued up for -stable, thanks.