netdev - Re: [PATCH] net: wireless: prefix header search paths with $(srctree)/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f29fc396b9df90d39c4e46bf85c0d7f23dd9ddc.camel@coelho.fi>
Date:   Mon, 28 Jan 2019 10:26:36 +0200
From:   Luca Coelho <luca@...lho.fi>
To:     Kalle Valo <kvalo@...eaurora.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com,
        Franky Lin <franky.lin@...adcom.com>,
        Intel Linux Wireless <linuxwifi@...el.com>,
        Johannes Berg <johannes.berg@...el.com>,
        netdev@...r.kernel.org,
        Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
        Chi-Hsien Lin <chi-hsien.lin@...ress.com>,
        Hin-Tak Leung <htl10@...rs.sourceforge.net>,
        Larry Finger <Larry.Finger@...inger.net>,
        Herton Ronaldo Krzesinski <herton@...onical.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        Wright Feng <wright.feng@...ress.com>,
        Arend van Spriel <arend.vanspriel@...adcom.com>,
        brcm80211-dev-list@...ress.com, linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] net: wireless: prefix header search paths with
 $(srctree)/

On Mon, 2019-01-28 at 10:21 +0200, Kalle Valo wrote:
> Masahiro Yamada <yamada.masahiro@...ionext.com> writes:
> 
> > Currently, the Kbuild core manipulates header search paths in a
> > crazy
> > way [1].
> > 
> > To fix this mess, I want all Makefiles to add explicit $(srctree)/
> > to
> > the search paths in the srctree. Some Makefiles are already written
> > in
> > that way, but not all. The goal of this work is to make the
> > notation
> > consistent, and finally get rid of the gross hacks.
> > 
> > Having whitespaces after -I does not matter since commit
> > 48f6e3cf5bc6
> > ("kbuild: do not drop -I without parameter").
> > 
> > I also removed one header search path in:
> > 
> >   drivers/net/wireless/broadcom/brcm80211/brcmutil/Makefile
> > 
> > I was able to compile without it.
> > 
> > [1]: https://patchwork.kernel.org/patch/9632347/
> > 
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> > ---
> > 
> >  drivers/net/wireless/broadcom/brcm80211/brcmfmac/Makefile | 4 ++--
> >  drivers/net/wireless/broadcom/brcm80211/brcmsmac/Makefile | 6 +++-
> > --
> >  drivers/net/wireless/broadcom/brcm80211/brcmutil/Makefile | 4 +---
> >  drivers/net/wireless/intel/iwlwifi/dvm/Makefile           | 2 +-
> >  drivers/net/wireless/intel/iwlwifi/mvm/Makefile           | 2 +-
> >  drivers/net/wireless/realtek/rtl818x/rtl8180/Makefile     | 2 +-
> >  drivers/net/wireless/realtek/rtl818x/rtl8187/Makefile     | 2 +-
> >  7 files changed, 10 insertions(+), 12 deletions(-)
> 
> Luca, is it ok if I take this to wireless-drivers-next even though it
> touches iwlwifi makefiles?

Sure, it's much easier like that.

Acked-by: Luca Coelho <luciano.coelho@...el.com>

--
Cheers,
Luca.