netdev - Re: [PATCH net] net: dsa: mv88e6xxx: Fix serdes irq setup going recursive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a9530fd9-0f69-5025-28f3-a671a9fe23ac@cogentembedded.com>
Date:   Mon, 28 Jan 2019 11:37:41 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc:     Vivien Didelot <vivien.didelot@...il.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: Fix serdes irq setup going
 recursive

Hello!

On 28.01.2019 0:48, Andrew Lunn wrote:

> Duec to a typo, mv88e6390_serdes_irq_setup() calls itself, rather than

    Due?

> mv88e6390x_serdes_irq_setup(). It then blows the stack, and shortly
> after the machine blows up.

    Never seen a stack overflow in the kernel... :-)

> Fixes: 2defda1f4b91 ("net: dsa: mv88e6xxx: Add support for SERDES on ports 2-8 for 6390X")
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

MBR, Sergei