netdev - Re: [Patch nf-next] nf_conntrack: fix error path in nf_conntrack_pernet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190128101832.rvdego4wxgcib6w4@salvia>
Date:   Mon, 28 Jan 2019 11:18:32 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     netdev@...r.kernel.org, netfilter-devel@...r.kernel.org,
        syzbot+fcee88b2d87f0539dfe9@...kaller.appspotmail.com,
        Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
        Florian Westphal <fw@...len.de>
Subject: Re: [Patch nf-next] nf_conntrack: fix error path in
 nf_conntrack_pernet_init()

On Wed, Jan 23, 2019 at 12:58:57PM -0800, Cong Wang wrote:
> When nf_ct_netns_get() fails, it should clean up itself,
> its caller doesn't need to call nf_conntrack_fini_net().
> 
> nf_conntrack_init_net() is called after registering sysctl
> and proc, so its cleanup function should be called before
> unregistering sysctl and proc.

Applies, thanks.