netdev - Re: [PATCH net] net: tls: Save iv in tls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190129172215.cnzhluzzqpj3l6sd@davejwatson-mba.local>
Date:   Tue, 29 Jan 2019 17:21:41 +0000
From:   Dave Watson <davejwatson@...com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] net: tls: Save iv in tls_rec for async crypto
 requests

On 01/28/19 11:06 PM, David Miller wrote:
> From: Dave Watson <davejwatson@...com>
> Date: Sun, 27 Jan 2019 00:57:38 +0000
> 
> > aead_request_set_crypt takes an iv pointer, and we change the iv
> > soon after setting it.  Some async crypto algorithms don't save the iv,
> > so we need to save it in the tls_rec for async requests.
> > 
> > Found by hardcoding x64 aesni to use async crypto manager (to test the async
> > codepath), however I don't think this combination can happen in the wild.
> > Presumably other hardware offloads will need this fix, but there have been
> > no user reports.
> > 
> > Fixes: a42055e8d2c30 ("Add support for async encryption of records...")
> > Signed-off-by: Dave Watson <davejwatson@...com>
> 
> Applied and queued up for -stable.

I'd like to merge TLS1.3 support to net-next, which depends on this
commit.  Can we get a net->net-next merge when convenient?  Thanks