[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20190129.093913.2116455131788944733.davem@davemloft.net>
Date: Tue, 29 Jan 2019 09:39:13 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: arjun@...lsio.com
Cc: netdev@...r.kernel.org, nirranjan@...lsio.com,
indranil@...lsio.com, dt@...lsio.com, leedom@...lsio.com
Subject: Re: [net-next] cxgb4/cxgb4vf: Program hash region for
{t4/t4vf}_change_mac()
From: Arjun Vynipadath <arjun@...lsio.com>
Date: Tue, 29 Jan 2019 15:18:50 +0530
> diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
> index 2fab87e..a8f78ea 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
> @@ -236,6 +236,74 @@ void t4vf_os_portmod_changed(struct adapter *adapter, int pidx)
> "inserted\n", dev->name, pi->mod_type);
> }
>
> +static inline int cxgb4vf_set_addr_hash(struct port_info *pi)
...
> +static inline int cxgb4vf_change_mac(struct port_info *pi, unsigned int viid,
> + int *tcam_idx, const u8 *addr,
> + bool persistent)
Please do not use the inline keyword in foo.c files.
Thank you.
Powered by blists - more mailing lists